[TIMOB-25749] Android: Fix loading of commonjs modules

[garymathews]

• Fix regression caused by [TIMOB-25597] Android: Fixed bug where multidexed apps crash on startup on Android 4.x #9694

TEST CASE

• Include com.foo.bar in a Titanium project
• Build project

JIRA Ticket

[jquick-axway]

CR: Pass

[lokeshchdhry]

@garymathews , I am getting this different error with the fix.

[ERROR] :  Failed to compile Java source files:
[ERROR] :  
[ERROR] :  /Users/lchoudhary/Desktop/workspaces/workspace_2018/TIMOB-25749/build/android/gen/com/app/timob25749/Timob25749Application.java:113: error: cannot find symbol
[ERROR] :  						(Class<KrollSourceCodeProvider>) Class.forName(className));
[ERROR] :  						       ^
[ERROR] :    symbol:   class KrollSourceCodeProvider
[ERROR] :    location: class Timob25749Application
[ERROR] :  Note: Some input files use unchecked or unsafe operations.
[ERROR] :  Note: Recompile with -Xlint:unchecked for details.
[ERROR] :  1 error
[ERROR] Application Installer abnormal process termination. Process exit value was 1

[garymathews]

@lokeshchdhry Updated PR

[lokeshchdhry]

@garymathews , Now I get this error:

[ERROR] :  Failed to compile Java source files:
[ERROR] :  
[ERROR] :  /Users/lchoudhary/Desktop/workspaces/workspace_2018/TIMOB-25749/build/android/gen/com/app/timob25749/Timob25749Application.java:11: error: cannot find symbol
[ERROR] :  import org.appcelerator.kroll.KrollSourceCodeProvider;
[ERROR] :                               ^
[ERROR] :    symbol:   class KrollSourceCodeProvider
[ERROR] :    location: package org.appcelerator.kroll
[ERROR] :  /Users/lchoudhary/Desktop/workspaces/workspace_2018/TIMOB-25749/build/android/gen/com/app/timob25749/Timob25749Application.java:114: error: cannot find symbol
[ERROR] :  						(Class<KrollSourceCodeProvider>) Class.forName(className));
[ERROR] :  						       ^
[ERROR] :    symbol:   class KrollSourceCodeProvider
[ERROR] :    location: class Timob25749Application
[ERROR] :  Note: Some input files use unchecked or unsafe operations.
[ERROR] :  Note: Recompile with -Xlint:unchecked for details.
[ERROR] :  2 errors
[ERROR] Application Installer abnormal process termination. Process exit value was 1

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

[lokeshchdhry]

FR Passed.

No error seen when using commonjs modules.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1