Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25771] Android: Fixed 7.0.2 app build failure for systems that require proxy access #9822

Merged
merged 5 commits into from Feb 28, 2018

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Feb 15, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-25771

Summary:

  • Caused by new gradle build step which needs to download ProGuard from maven the first time it is ran.
  • Now generates a "gradle.properties" file in the project's build folder which provides a copy of the "appc config" proxyServer settings.
  • I've tested this script change via a proxy on both Mac and Windows.

Test:
Run the test described in TIMOB-25771.
(It would be easier to test this in the office. I can show QE what to do.)

….2 if system requires proxy access to Internet

- Now copies appc config "proxyServer" settings to project's generated "gradle.properties" file.
  * Was failing because gradle needs to download proguard from maven repository.
@build
Copy link
Contributor

build commented Feb 15, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@jquick-axway jquick-axway changed the title [TIMOB-25771] Android: Fixed 7.0.2 build failure for systems that require proxy access [TIMOB-25771] Android: Fixed 7.0.2 app build failure for systems that require proxy access Feb 15, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

App builds fine using a proxy.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit c859b5e into tidev:master Feb 28, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants