Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25773] Android: Fixed app build failure caused by " -" in project path #9824

Merged
merged 4 commits into from Feb 21, 2018
Merged

[TIMOB-25773] Android: Fixed app build failure caused by " -" in project path #9824

merged 4 commits into from Feb 21, 2018

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Feb 15, 2018 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-25773

Summary:

  • This issue was introduced in Titanium 7.0.2.
  • Now double quotes paths added to ProGuard configuration file.
  • Now double quotes paths passed to gradle shell/batch file.
    • Needed on Windows. Not required on Mac, but still works.
  • Also escapes double quotes in file/folder names since that is legal on Mac and Linux. (Not allowed on Windows.)

Test:

  1. Go to a Mac machine.
  2. Create a "Classic" Titanium app named "Dash -Test". (Note the space and dash.)
  3. Make sure the project folder name is also "Dash -Test".
  4. Build for Android.
  5. Verify that the APK is successfully created.
  6. Repeat steps 2-5 on Windows.

@jquick-axway
[TIMOB-25773] Android: Fixed app build failure caused by " -" in proj…
78d6b2b 
…ect path. (Introduced in 7.0.2.)

- Now double quotes paths added to ProGuard configuration file.
- Now double quotes paths passed to gradle shell/batch file.
  * Needed on Windows. Not required on Mac, but still works.
@jquick-axway jquick-axway added this to the 7.2.0 milestone Feb 15, 2018
@build
Copy link
Contributor

build commented Feb 15, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@jquick-axway jquick-axway mentioned this pull request Feb 15, 2018
Merged
garymathews
garymathews approved these changes Feb 15, 2018
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@mukherjee2 mukherjee2 self-requested a review February 21, 2018 23:26
mukherjee2
mukherjee2 approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passes. See comments in 7_1_X PR for this ticket.

@mukherjee2 mukherjee2 merged commit da62deb into tidev:master Feb 21, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@mukherjee2 mukherjee2 mukherjee2 approved these changes

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @garymathews @mukherjee2 @sgtcoolguy