Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7_1_X][TIMOB-20522] Update Geolocation to use FusedLocationClient #9826

Merged
merged 9 commits into from Feb 21, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.1.0 milestone Feb 15, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.
FusedLocationProviderClient works as expected when ti.playservices module is included in the project & falls back to old behaviour if not.

Also, No crash is seen if wrong accuracy like Ti.Geolocation.ACCURACY_BEST_FOR_NAVIGATION is provided which is not meant for Android.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry
Copy link
Contributor

@garymathews , On a genymotion emulator with no playservices I don't see any location events. I think its not falling back to old behaviour.

@build
Copy link
Contributor

build commented Feb 21, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry lokeshchdhry merged commit abed6d6 into tidev:7_1_X Feb 21, 2018
@lokeshchdhry
Copy link
Contributor

Oops forgot to comment before merging.

Checked the changes & geolocation works as expected in emulator without google playservices.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants