[7_1_X][TIMOB-25773] Android: Fixed app build failure caused by " -" in project path #9827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect path. (Introduced in 7.0.2.) - Now double quotes paths added to ProGuard configuration file. - Now double quotes paths passed to gradle shell/batch file. * Needed on Windows. Not required on Mac, but still works.
mukherjee2
approved these changes
Feb 21, 2018
There was a problem hiding this comment.
Passed FR with this environment:
Node Version: 8.9.1
NPM Version: 5.5.1
Mac OS: 10.13.1
Appc CLI: 7.0.2
Appc CLI NPM: 4.2.12
Titanium SDK version: 7.1.0.v20180215121109
Appcelerator Studio vers 5.0.0
Android 8.0
I reproduced the error with GA version of the SDK, and then built the demo app again with the fix, and the app launched with no errors.
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25773
Cherry Pick of: #9824