[7_1_X][TIMOB-25619] Android: Allow non-file TiBlob to be previewed #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssjsamir
approved these changes
Feb 22, 2018
There was a problem hiding this comment.
CR: #9771
FR Passed Was able to see a a preview of non-file TiBlob
Test Steps:
- Created a titanium project with the build form this PR
- Added the above code in to the project
- Ran the project
- Was able to view the blob without any runtime errors (which were seen on older versions of the SDK
- Also saw the following in the console
[INFO] : success, displaying preview
Test Environment
APPC Studio: 5.0.0.201711280737
APPC CLI: 7.0.1
Device: Nexus 6p (8.1.0)
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 8.9.1
garymathews
force-pushed
the
TIMOB-25619_71X
branch
from
facb251
to
9d8ba85
Compare
Generated by 🚫 dangerJS |
garymathews
force-pushed
the
TIMOB-25619_71X
branch
from
6544fed
to
d7a4c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket