Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25522] (7_1_X) iOS: Add "navigationWindow" property to Ti.UI.Window, add unit-tests for all nav-window API's #9848

Closed
wants to merge 6 commits into from

Conversation

hansemannn
Copy link
Collaborator

@build
Copy link
Contributor

build commented Feb 16, 2018

Fails
🚫

😥 npm test failed. See below for details.

Messages
📖
> titanium-mobile@7.1.0 test /Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9848-SEVZR5AGD3ZHNYVQ54KA2VXVXZXEUV5EUMKQWKL2TT4ZAKLVGLUA
> grunt

Running "appcJs:src" (appcJs) task

Running "eslint:src" (eslint) task

/Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9848-SEVZR5AGD3ZHNYVQ54KA2VXVXZXEUV5EUMKQWKL2TT4ZAKLVGLUA/android/cli/commands/_buildModule.js
554:18  warning  Found non-literal argument to RegExp Constructor  security/detect-non-literal-regexp

/Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9848-SEVZR5AGD3ZHNYVQ54KA2VXVXZXEUV5EUMKQWKL2TT4ZAKLVGLUA/tests/Resources/ti.ui.ios.navigationwindow.addontest.js
 13:2  warning  'utilities' is assigned a value but never used                   no-unused-vars
 44:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 47:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 53:3  warning  All 'var' declarations must be at the top of the function scope  vars-on-top
 54:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 59:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 62:4  error    'finish' is not defined                                          no-undef
 64:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 67:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 71:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 76:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 80:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 85:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 87:4  error    'finish' is not defined                                          no-undef
 89:1  error    Trailing spaces not allowed                                      no-trailing-spaces
 96:1  error    Trailing spaces not allowed                                      no-trailing-spaces
101:1  error    Trailing spaces not allowed                                      no-trailing-spaces
105:1  error    Trailing spaces not allowed                                      no-trailing-spaces
109:4  error    'finish' is not defined                                          no-undef
111:1  error    Trailing spaces not allowed                                      no-trailing-spaces
117:1  error    Trailing spaces not allowed                                      no-trailing-spaces
122:1  error    Trailing spaces not allowed                                      no-trailing-spaces
132:4  error    'finish' is not defined                                          no-undef
134:1  error    Trailing spaces not allowed                                      no-trailing-spaces

✖ 25 problems (22 errors, 3 warnings)
18 errors, 0 warnings potentially fixable with the `--fix` option.

Warning: Task "eslint:src" failed.� Use --force to continue.

Aborted due to warnings.
npm ERR! Test failed.  See above for more details.

Generated by 🚫 dangerJS

@hansemannn hansemannn closed this Feb 16, 2018
@hansemannn hansemannn removed this from the 7.1.0 milestone Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants