[TIMOB-24206] iOS: Fix image leaks on JSCore, use JSCore by default inside iOS-core as well #9850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
vijaysingh-axway
suggested changes
Feb 22, 2018
This reverts commit 095911e.
hansemannn
changed the title
|
@vijaysingh-axway PR updated with the regards to the discussion on Teams. We have to extremely sensitive tests to ensure the JSGarbageCollect plays nice. |
iphone/Classes/TiUIView.m
Outdated
| @@ -605,6 +605,7 @@ - (void)setBackgroundImage_:(id)image | |||
| if (backgroundRepeat) { | |||
| [self renderRepeatedBackground:bgImage]; | |||
| } else { | |||
| RELEASE_TO_NIL([self backgroundImageLayer].contents); | |||
There was a problem hiding this comment.
This line is causing crash. If I remove this line, JSGarbageCollect is working nice. I'll do more testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24206