Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7_1_X][TIMOB-9366] Android: Added "radial" gradient support #9855

Merged
merged 8 commits into from Feb 27, 2018

Conversation

jquick-axway
Copy link
Contributor

jquick-axway and others added 3 commits February 16, 2018 17:34
- Also modified "TiUIView" to log exception thrown by "TiGradientDrawable" constructor. Particularly for invalid "type" parameters.
@build
Copy link
Contributor

build commented Feb 22, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS once updated from master PR

- Fixed bug where if start radius is zero, a single transparent pixel can be seen in center of circle.
- Fixed bug where Android 4.2-4.4 shows glitchy graphics when start radius is greater than 0.0 and backfillStart is false.
  * This was a Google bug that had to be worked-around by adding a color offset starting from 0.0 (center of circle).
- Fixed bug where outer edge of circle would wrongly back-fill if radius was greater than 255 and if border was applied to view (HW acceleration disabled) or GPU shader is limited to "lowp" 1 byte floats.
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Feb 27, 2018

FR Passed.

Used the test code in the ticket & Start Radius, End Radius, Back Fill End & Back Fill Start works as expected in various scenarios.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1
Emulator: Android 4.1, 4.2.2

@build build added the android label Feb 27, 2018
@build build added the docs label Feb 27, 2018
@lokeshchdhry lokeshchdhry merged commit b1e6919 into tidev:7_1_X Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants