Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7_1_X][TIMOB-25591] Android: Programmatically check whether app has notification permission on Android. #9858

Merged
merged 8 commits into from Feb 26, 2018

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Feb 19, 2018

@build
Copy link
Contributor

build commented Feb 19, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator

We should really refactor the Android notifications namespace..For example, remoteNotificationsEnabled is very similar, but developers need to curate two pairs of APIs.

@ypbnv
Copy link
Contributor Author

ypbnv commented Feb 20, 2018

@hansemannn Can we find a common ground between iOS and Android notifications systems? I am not familiar with the former enough. Does it have a separation between local and remote notifications? Maybe we can create Ti.Notifications namespace where we could transfer Android's Notification, NotificationChannel and NotificationManager namespaces, combine what they have in common with iOS?

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Feb 26, 2018

FR Passed.

areNotificationsEnabled() works as expected.

  1. Notifications are enabled by default & areNotificationsEnabled() returns true.
  2. After turning off notifications in settings for the app areNotificationsEnabled() returns false.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1
Emulator: Android 4.1

@lokeshchdhry lokeshchdhry merged commit fd123d2 into tidev:7_1_X Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants