Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25765]: iOS 11 Scrollview layout error when set window with includeOpaqueBars and extendEdges #9866

Merged
merged 3 commits into from Feb 22, 2018
Merged

[TIMOB-25765]: iOS 11 Scrollview layout error when set window with includeOpaqueBars and extendEdges #9866

merged 3 commits into from Feb 22, 2018

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added the ios label Feb 22, 2018
@build
Copy link
Contributor

build commented Feb 22, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

hansemannn
hansemannn approved these changes Feb 22, 2018
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansemannn
Copy link
Collaborator

Please still add unit-tests for the properties. It should not crash when using includeOpaqueBars and extendEdges, independent from seeing the UI.

@hansemannn hansemannn added this to the 7.2.0 milestone Feb 22, 2018
@ewieberappc
Copy link
Contributor

FR Passed. Tested using the provided sample code and the scrollview and window test suites

@build build added the ios label Feb 22, 2018
@ewieberappc ewieberappc merged commit ecf222f into tidev:master Feb 22, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @hansemannn @ewieberappc @sgtcoolguy