[7_1_X][TIMOB-25585] Android: MediaModule creates temporary files that don't delete on app exit. #9873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
ssjsamir
approved these changes
Feb 23, 2018
There was a problem hiding this comment.
CR In: #9666
FR Passed Was able to see that temporary files were no longer stored and did not require to be manually deleted.
Test Steps:
- Created a titanium project with the build form this PR
- Added the above code in to the project ([TIMOB-25585] Android: MediaModule creates temporary files that don't delete on app exit. #9666)
- Ran the project
- Took a photo
- pressed "list pictures"
- saw tiaxxx.xxx temp files no longer being saved in the list (unlike in 7.0.2.GA)
Test Environment
APPC Studio: 5.0.0.201711280737
APPC CLI: 7.0.1
Device: Nexus 6p (8.1.0)
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 8.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25585
Description:
Backport of: #9666