Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25762] : iOS 11.3 beta- Loading HTML in Webview errors when accessing EventListener #9877

Merged
merged 8 commits into from Feb 26, 2018
Merged

[TIMOB-25762] : iOS 11.3 beta- Loading HTML in Webview errors when accessing EventListener #9877

merged 8 commits into from Feb 26, 2018

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Feb 23, 2018 •
edited by hansemannn

JIRA: https://jira.appcelerator.org/browse/TIMOB-25762

EDIT Hans: no tests because it fixes an existing asynchronous UI behavior (see the linked JIRA for details).

@hansemannn hansemannn added this to the 7.2.0 milestone Feb 23, 2018
hansemannn
hansemannn approved these changes Feb 23, 2018
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved. Tested with the test-case attached to JIRA and all existing Ti.UI.WebView unit-tests. I've also ran a static code analysis and validated possible leaks, it all passes.

@build build added the ios label Feb 23, 2018
@ewieberappc
Copy link
Contributor

FR Passed. Comments on 7_1_X branch. Workaround is successful

@build build added the ios label Feb 23, 2018
@build
Copy link
Contributor

build commented Feb 26, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@ewieberappc ewieberappc merged commit 9feaa7c into tidev:master Feb 26, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

@ewieberappc ewieberappc Awaiting requested review from ewieberappc

Assignees
No one assigned
Labels
in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @ewieberappc @build @hansemannn @sgtcoolguy