Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25755] Android: Allow WebView to support certificate requests #9882

Merged
merged 6 commits into from May 23, 2018
Merged

[TIMOB-25755] Android: Allow WebView to support certificate requests #9882

merged 6 commits into from May 23, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Feb 24, 2018 •
edited

  • Allow Titanium.UI.WebView to support certificate requests
    • NOTE: Android 4.4 does not support this and will fallback to previous behaviour
TEST CASE
  • See JIRA ticket

JIRA Ticket

@garymathews garymathews added this to the 7.2.0 milestone Feb 24, 2018
@build build added the android label Feb 24, 2018
@build build added the android label Feb 26, 2018
@build build added the android label Feb 26, 2018
@build build added the android label Feb 26, 2018
@build build added the android label Feb 26, 2018
ypbnv
ypbnv approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build build added the android label Feb 27, 2018
@longton95
Copy link
Contributor

@garymathews Is there any other way I can test this without the customer's cert?

@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
@build
Copy link
Contributor

build commented May 23, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy merged commit 481f561 into tidev:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @longton95 @build @ypbnv @sgtcoolguy