Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-5621] Android: Improve log quality #9884

Closed
wants to merge 2 commits into from
Closed

[AC-5621] Android: Improve log quality #9884

wants to merge 2 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Feb 24, 2018

JIRA: https://jira.appcelerator.org/browse/AC-5621

Optional Description:

Just showing TiAPI logs

don't merge! won't show any module log

@build
Copy link
Contributor

build commented Feb 24, 2018

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build
Copy link
Contributor

build commented Jun 27, 2018

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator

@sgtcoolguy are you okay with this change?

@sgtcoolguy
Copy link
Contributor

@hansemannn I think @m1ga stated this shouldn't be merged because it breaks module logging?

@hansemannn
Copy link
Collaborator

Oh yes, you're right. @m1ga Are you planning to update this or should we close it for now?

@m1ga
Copy link
Contributor Author

m1ga commented Jun 28, 2018

I close it for now since I wasn't able to fix the module part.

@m1ga m1ga closed this Jun 28, 2018
@m1ga m1ga deleted the log branch December 10, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants