Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25753] Android: Fixed bug where ScrollView "width" ignores Ti.UI.SIZE as of 6.3.0 #9895

Merged
merged 3 commits into from Mar 21, 2018
Merged

[TIMOB-25753] Android: Fixed bug where ScrollView "width" ignores Ti.UI.SIZE as of 6.3.0 #9895

merged 3 commits into from Mar 21, 2018

Conversation

jquick-axway
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-25753

Test:

  1. Run test attached to TIMOB-25753 on Android.
  2. Verify ScrollView is shrunk width-wise to just fit the label as shown in TIMOB-25753 attached Screenshot-Good.png.

@jquick-axway jquick-axway added this to the 7.2.0 milestone Feb 28, 2018
@jquick-axway jquick-axway mentioned this pull request Feb 28, 2018
Merged
@build build added the android label Feb 28, 2018
@build
Copy link
Contributor

build commented Feb 28, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

Scrollview width respects Ti.UI.SIZE.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0

@lokeshchdhry
Copy link
Contributor

Waiting for CR to merge.

@lokeshchdhry lokeshchdhry merged commit bf211dc into tidev:master Mar 21, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @lokeshchdhry @sgtcoolguy