New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-9366] update radial backgroundGradient example to match implementation #9903
Conversation
Generated by 🚫 dangerJS |
apidoc/Titanium/UI/View.yml
Outdated
@@ -1119,7 +1119,7 @@ properties: | |||
startPoint: { x: 50, y: 50 }, | |||
endPoint: { x: 50, y: 50 }, | |||
colors: [ 'red', 'blue'], | |||
startRadius: '90%', | |||
startRadius: 90, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should set startRadius to 50
instead.
This way, a full circle will just-fit within the view.
Note that setting this to 90
would make the radius larger than the old 90%
setting. On iOS, 100%
equals sqrt(width^2, height^2) / 2
, which is the distance between the center of the view to one of its corners.
@jquick-axway good point! Updated, will update the other PR too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
FR Passed. Example works properly on both Android & IOS. Studio Ver: 5.0.0.201712081732 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-9366
The current example in the documentation works only for iOS. I updated it to reflect both platforms