Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-9366] update radial backgroundGradient example to match implementation #9903

Merged
merged 2 commits into from Mar 5, 2018
Merged

Conversation

Topener
Copy link
Sponsor Contributor

@Topener Topener commented Mar 5, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-9366

The current example in the documentation works only for iOS. I updated it to reflect both platforms

@Topener Topener changed the title update radial backgroundGradient example to match implementation [TIMOB-9366} update radial backgroundGradient example to match implementation Mar 5, 2018
@build
Copy link
Contributor

build commented Mar 5, 2018

Messages
📖

🎉 Another contribution from our awesome community member, Topener! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@@ -1119,7 +1119,7 @@ properties:
startPoint: { x: 50, y: 50 },
endPoint: { x: 50, y: 50 },
colors: [ 'red', 'blue'],
startRadius: '90%',
startRadius: 90,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set startRadius to 50 instead.
This way, a full circle will just-fit within the view.

Note that setting this to 90 would make the radius larger than the old 90% setting. On iOS, 100% equals sqrt(width^2, height^2) / 2, which is the distance between the center of the view to one of its corners.

@Topener
Copy link
Sponsor Contributor Author

Topener commented Mar 5, 2018

@jquick-axway good point! Updated, will update the other PR too

@Topener Topener changed the title [TIMOB-9366} update radial backgroundGradient example to match implementation [TIMOB-9366] update radial backgroundGradient example to match implementation Mar 5, 2018
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

Example works properly on both Android & IOS.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0

@lokeshchdhry lokeshchdhry merged commit 313de85 into tidev:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants