Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25409] Android: Resolve remote content uris #9906

Merged
merged 3 commits into from Mar 21, 2018
Merged

[TIMOB-25409] Android: Resolve remote content uris #9906

merged 3 commits into from Mar 21, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Mar 5, 2018 •
edited

  • Resolve remote content uris
NOTE: no tests as openPhotoGallery requires user input
TEST CASE
Ti.Media.openPhotoGallery({
    mediaTypes: [ Ti.Media.MEDIA_TYPE_PHOTO ],
    success: function (e) {
        Ti.Media.previewImage({ image: e.media });
    },
    error: function (e) {
        console.error(e);
    }
});

JIRA Ticket

@garymathews garymathews added this to the 7.1.1 milestone Mar 5, 2018
@build build added the android label Mar 5, 2018
@build
Copy link
Contributor

build commented Mar 5, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the android label Mar 5, 2018
@garymathews garymathews requested a review from ypbnv March 8, 2018 19:09
ypbnv
ypbnv reviewed Mar 12, 2018
View reviewed changes
android/titanium/src/java/org/appcelerator/titanium/io/TitaniumBlob.java
} catch (FileNotFoundException e) {
Log.e(TAG, "could not find " + url);
}
}
} finally {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the ticket:
Would we want to catch exceptions when trying to get a cursor from the query() calls when the result is null? We can log a warning or an error message.

ypbnv
ypbnv approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build build added the android label Mar 20, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

No crash see when getting an image from google drive.

Studio Ver: 5.1.0
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 0d80c4f into tidev:master Mar 21, 2018
@garymathews garymathews mentioned this pull request Mar 22, 2018
Merged
@frankieandone frankieandone mentioned this pull request May 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
7.1.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @ypbnv @ssjsamir