Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17889] Android: Support Integer to Boolean conversion #9907

Merged
merged 3 commits into from May 8, 2018

Conversation

garymathews
Copy link
Contributor

  • Support Javascript Integer to Boolean conversion
TEST CASE
const view = Ti.UI.createView({ bubbleParent: 1 });
if (view.bubbleParent === true) {
    alert('success!');
}

JIRA Ticket

@garymathews garymathews added this to the 7.1.1 milestone Mar 5, 2018
@build build added the android label Mar 6, 2018
@hansemannn hansemannn modified the milestones: 7.1.1, 7.2.0 Apr 3, 2018
@sgtcoolguy sgtcoolguy self-requested a review April 23, 2018 18:17
@lokeshchdhry
Copy link
Contributor

FR Passed.

Ti.Convert successfully handles conversion of integer to boolean.

Studio Ver: 5.1.0.201804230827
SDK Ver: 7.2.0 local build
OS Ver: 10.13.4
Xcode Ver: Xcode 9.3
Appc NPM: 4.2.13
Appc CLI: 7.0.3
Daemon Ver: 1.1.1
Ti CLI Ver: 5.1.0
Alloy Ver: 1.12.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0
Emulator: ⇨ Android 4.1.2

@build
Copy link
Contributor

build commented May 8, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry lokeshchdhry merged commit d3eb6ce into tidev:master May 8, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants