[TIMOB-13379] Implement console.time/timeEnd

[ewanharris]

JIRA: https://jira.appcelerator.org/browse/TIMOB-13379

Implement console.time/timeEnd according to https://console.spec.whatwg.org/#time, with the optional log on console.time('duplicate label') implemented, and a slight deviation to log a warning when calling console.timeEnd('does not exist').

iOS can do a higher precision on the timing due to the implementation being in native but I nerfed for parity, happy to un-nerf though.

Test code

console.time('set label'); // Set custom labels
console.time('set label'); // Should log "Label set label already exists" at a warn lebel
setTimeout(() => {
    console.timeEnd('set label'); // Should log "set label: 100ms" (not exactly 100ms)
}, 100);

console.time(); // Defaults to "default" if no value passed in
setTimeout(() => {
    console.timeEnd(); // Should log "set label: 5000ms" (not exactly 5000ms)
}, 5000);
console.timeEnd('No exist') // Should log "Label No exist does not exist" at warn level

Output

iOS
[WARN]  Label set label already exists
[WARN]  Label No exist does not exist
[INFO]  set label: 106ms
[INFO]  default: 5003ms

Android
[WARN]  Label set label already exists
[WARN]  Label No exist does not exist
[INFO]  set label: 127ms
[INFO]  default: 5004ms

[ewanharris]

imo, this would read nicer using template literals. Which are supported by the v8 version I believe. What're our best practices for the JS code on Android. The eslint options specify ES5

  "parserOptions": {
    "ecmaVersion": 5,
    "sourceType": "script"
  }

[garymathews]

I'm fine with that since it's supported.

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

[hansemannn]

Should a developer be able to pass an array of argumenzts, e.g. console.time(['test', 'foo'])? If not, change the arg-type to id and use ENSURE_SINGLE_ARG(args, NSString); to force a string directly. Example:

- (void)time:(id)label
{
  ENSURE_SINGLE_ARG(label, NSString);
  ...
}

Same for timeEnd probably.

[garymathews]

Could you move this to the top of console.js ?

[sgtcoolguy]

Isn't there an actual default property you can set here?

[ewanharris]

Wasn't aware of that, updated to include default and optional in docs. Making a note to familiarise myself with our doc stuff too :)

[sgtcoolguy]

vars should be declared at top of scope, since they get hoisted up there.

[sgtcoolguy]

Also, given that we know V8 is newer and can support ES6 natively, is there any reason we can't start making use of es6 syntax in runtime JS code? (i.e. template strings here, use of const/let)

[sgtcoolguy]

e.g. https://github.com/nodejs/node/blob/master/lib/console.js#L166-L184

[ewanharris]

@sgtcoolguy Updated to use template literals, const and a Map instead of a plain object

[ewanharris]

FYI I filed https://jira.appcelerator.org/browse/TIMOB-25892 to hook the linting up in this folder as grunt lint doesn't include it currently

[sgtcoolguy]

Windows PR: appcelerator/titanium_mobile_windows#1209