Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_1_X][TIMOB-25849] Android: Always specify image mime-type #9919

Merged
merged 2 commits into from Mar 8, 2018
Merged

[7_1_X][TIMOB-25849] Android: Always specify image mime-type #9919

merged 2 commits into from Mar 8, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.1.0 milestone Mar 8, 2018
@build build added the android label Mar 8, 2018
@build
Copy link
Contributor

build commented Mar 8, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the android label Mar 8, 2018
@build build added the android label Mar 8, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

Width & height of the selected photo is successfully retrieved.
If we try to select a video the behavior is not enforced on all devices as said by @garymathews above. On a Nexus 6P we are not allowed to select a video & on a Nexus 5 we can select a video but then its width & height is retrieved as zero.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 8768d5f into tidev:7_1_X Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway Awaiting requested review from jquick-axway

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @lokeshchdhry