Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(7_1_X) Bump node-appc to 0.2.44 for [TIMOB-25429] CLI: Support detection of Java 9 #9925

Closed
wants to merge 1 commit into from
Closed

(7_1_X) Bump node-appc to 0.2.44 for [TIMOB-25429] CLI: Support detection of Java 9 #9925

wants to merge 1 commit into from

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Mar 9, 2018 •
edited

@sgtcoolguy sgtcoolguy added this to the 7.1.1 milestone Mar 9, 2018
@build
Copy link
Contributor

build commented Mar 9, 2018

Fails
🚫

Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.UI.WebView userAgent 10.085 Error: timeout of 10000ms exceeded

Generated by 🚫 dangerJS

@ewanharris
Copy link
Collaborator

@sgtcoolguy Not sure whether the intention of this PR is to iron out all the issue here, but while testing I found https://jira.appcelerator.org/browse/TIMOB-25799. It's a simple fix, changing -Djava.ext.dirs=' + this.androidInfo.sdk.platformTools.path to '-classpath', this.androidInfo.sdk.platformTools.path, and it seems to work across Java 9 and 8

@ewanharris
Copy link
Collaborator

Taken over by #9965 (7_1_X) and #9964 (master)

@ewanharris ewanharris closed this Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris Awaiting requested review from ewanharris

Assignees
No one assigned
Labels
android bug cli 📟
Projects
None yet
Milestone
7.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgtcoolguy @build @ewanharris