[TIMOB-25855] Android: TextArea lines and maxLines support #9927

m1ga · 2018-03-11T12:48:10Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-25855

var win = Ti.UI.createWindow({
	backgroundColor: '#fff',
	
});

var sv = Ti.UI.createScrollView({
	layout:"vertical",
	height:Ti.UI.FILL
})

var tf1 = Ti.UI.createTextArea({
	borderColor: "#000",
	borderWidth: 1,
	color: "#000",
	width: 200,
	hintText:"1 to 5",
	hintTextColor:"#999",
	lines: 1,
	maxLines: 5,
	
})

var tf2 = Ti.UI.createTextArea({
	lines: 2,
	maxLines: 2,
	borderColor: "#000",
	borderWidth: 1,
	color: "#000",
	width: 200,
	hintText:"2 to 2 -> setting lines to 4",
	hintTextColor:"#999"
});
tf2.lines = 4;


var tf3 = Ti.UI.createTextArea({
	lines: 2,
	maxLines: 2,
	borderColor: "#000",
	borderWidth: 1,
	color: "#000",
	width: 200,
	hintText:"2 to 2",
	hintTextColor:"#999"
});
tf3.maxLines = 2;

var tf4 = Ti.UI.createTextArea({
	lines: 2,
	maxLines: 2,
	borderColor: "#000",
	borderWidth: 1,
	color: "#000",
	width: 200,
	hintText:"2 to 2 -> setting max to 4",
	hintTextColor:"#999"
});
tf4.maxLines = 4;

var textField1 = Ti.UI.createTextField({
	borderColor: "#000",
	borderWidth: 1,
	color: "#000",
	width: 200,
	hintText:"Textfield",
	hintTextColor:"#999"
});

var lbl1 = Ti.UI.createLabel({
	color:"#000",
	bottom: 10,
	text:"one line"
});
var lbl2 = Ti.UI.createLabel({
	color:"#000",
	bottom: 10,
	text:"two\nline"
});
var lbl3 = Ti.UI.createLabel({
	color:"#000",
	bottom: 10,
	text:"max 3 multi\n1 multi\n2 multi\n3 multi\n4 multi\nmulti\nline",
	maxLines: 3
});
var lbl4 = Ti.UI.createLabel({
	color:"#000",
	bottom: 10,
	text:"line 2 multi\n1 multi\n2 multi\n3 multi\n4 multi\nmulti\nline",
	lines: 2
});
win.add(sv);
sv.add(tf1);
sv.add(tf2);
sv.add(tf3);
sv.add(tf4);
sv.add(textField1);
sv.add(lbl1);
sv.add(lbl2);
sv.add(lbl3);
sv.add(lbl4);
win.open();

jquick-axway · 2018-03-12T18:32:08Z

@m1ga, I remember the call order for Google's TextView setLines() and setMaxLines() being important. See our Label code here. You may need to do something similar.
https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUILabel.java#L698

From what I remember, calling setLines() will also reset min-lines and max-lines. So, if you call setLines(), you need to call setMaxLines() right afterwards to restore what was last set.

Try testing it with the following...

var tf = Ti.UI.createTextArea({
	lines: 2,
	maxLines: 2,
});
tf.lines = 4;

Also note that the TiUIText Java class you are editing is used by Titanium's TextField and TextArea. So, we need to test that this doesn't break a single-line TextField. Our TiUILabel code I linked above supports both single-line and multiline, so, it's probably a good code base to work off of.

Thanks.

m1ga · 2018-03-18T11:44:04Z

@jquick-axway thanks for the tips! I'm checking that. TextFields shouldn't be a problem since I only set the new values if !field. But I'll add this to the check.
~~I current have a problem if I put everything into a vertical layout view. Very strange but I'm on it~~ was using the wrong sdk

m1ga · 2018-03-18T12:36:58Z

I've added a better example with more cases. It actually looks correct even with setting tf.lines = 4; after creating it with 2/2. It will show 4 lines but still uses the maxLines:2 so you have 2 empty non-usable lines below it.

jquick-axway · 2018-05-01T23:01:20Z

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIText.java

+		}
+
+		if (d.containsKey(TiC.PROPERTY_MAX_LINES)) {
+			if (!field) tv.setMaxLines(TiConvert.toInt(d, TiC.PROPERTY_MAX_LINES));


From looking at Google's Textview Java code, they don't expect setMaxLines() to be set to a value <= 0. Google defaults this to Integer.MAX_VALUE by default. We should do the same if the property is set to <= 0. This is to avoid possible layout issues.
https://github.com/aosp-mirror/platform_frameworks_base/blob/master/core/java/android/widget/TextView.java#L658

I believe we might have a similar issue with Android's setLines() method since it set private member variable mMaximum (used as max lines) to the given lines value.
https://github.com/aosp-mirror/platform_frameworks_base/blob/master/core/java/android/widget/TextView.java#L4616

So, if the lines property is <= 0, then we should call setMinLines(0) instead.

I think the best thing to do is to apply lines and maxLines property changes via a method like how I'm doing it in the code below. You don't need the setSingleLine() call, but you do need to call setMaxLines() after calling setLines() since Google resets the maximum afterwards.
https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUILabel.java#L706

ah nice, I'll copy the parts over to the UIText!

jquick-axway · 2018-05-01T23:02:56Z

android/modules/ui/src/java/ti/modules/titanium/ui/TextAreaProxy.java

@@ -58,6 +60,8 @@ public TextAreaProxy()
 	{
 		super();
 		defaultValues.put(TiC.PROPERTY_VALUE, "");
+		defaultValues.put(TiC.PROPERTY_LINES, 1);


I think lines should default to -1.

For backward compatibility, we should respect the TextArea's height property. The lines property is used to set the height of the TextArea by line height instead (definitely a good feature) but the developer should opt-in to it.

jquick-axway · 2018-05-01T23:07:16Z

apidoc/Titanium/UI/TextArea.yml

@@ -366,6 +366,14 @@ properties:
    default: <Titanium.UI.KEYBOARD_DEFAULT>
    platforms: [android, iphone, ipad]

+  - name: lines
+    summary: Line count of text field input.
+    description: Sets the initial size of lines that the field will have at start.


Let's make it clear that lines sets the TextArea height by line height... and get rid of the "text field" references since this only applies to text areas.

How about the following...

summary: Number of lines tall the text area height will be, if set. description: Sets the height of the text are by line height. Set to -1 to respect the view's height property instead.

Fixed typo.

jquick-axway

CR: Pass

Thanks @m1ga :)

build · 2018-05-10T09:02:55Z

	Fails
🚫	🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

	Messages
📖	🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

build · 2018-06-26T18:46:58Z

	Messages
📖	🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

hansemannn · 2018-06-26T18:52:35Z

@m1ga Can you sign the CLA again? There is a new server for it. Also, a unit-test for each property would be great!

…to maxlines

m1ga · 2018-06-27T18:15:25Z

👍 test added!

hansemannn · 2018-06-27T19:09:12Z

Looks great, ready for merge!

android: lines and maxLines

0cafdb1

build added android community 🔥 docs needs tests 🚨 labels Mar 11, 2018

Topener changed the title ~~[AC-5653] Android: TextArea lines and maxLines support~~ [TIMOB-25855] Android: TextArea lines and maxLines support Mar 12, 2018

jquick-axway self-requested a review March 19, 2018 20:43

jquick-axway mentioned this pull request Mar 21, 2018

[TIMOB-25671]Android : TextField's some returnKeyType values not firing 'return' event #9933

Merged

jquick-axway suggested changes May 1, 2018

View reviewed changes

m1ga and others added 3 commits May 4, 2018 17:22

doc update, updateTextField method, range check

a3c5eb4

Merge branch 'master' into maxlines

b6b677c

Update TextArea.yml

4f97535

Fixed typo.

jquick-axway approved these changes May 4, 2018

View reviewed changes

jquick-axway added the in-qe-testing 🕵 label May 4, 2018

Merge branch 'master' into maxlines

a84b3f5

build added android community 🔥 docs needs tests 🚨 labels May 10, 2018

Merge branch 'master' into maxlines

00b0ebf

sgtcoolguy added this to the 7.4.0 milestone Jun 26, 2018

Merge branch 'master' into maxlines

7ce8fb1

hansemannn added 2 commits June 26, 2018 20:51

Update TextArea.yml

9c02130

Update TextArea.yml

daf9cb8

m1ga and others added 3 commits June 27, 2018 19:55

test

ae515ae

Merge branch 'maxlines' of https://github.com/m1ga/titanium_mobile in…

e58a6ef

…to maxlines

Merge branch 'master' into maxlines

df8c3a2

build removed the needs tests 🚨 label Jun 27, 2018

hansemannn merged commit cb97b36 into tidev:master Jun 27, 2018

hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018

m1ga deleted the maxlines branch December 10, 2022 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-25855] Android: TextArea lines and maxLines support #9927

[TIMOB-25855] Android: TextArea lines and maxLines support #9927

m1ga commented Mar 11, 2018 •

edited

jquick-axway commented Mar 12, 2018

m1ga commented Mar 18, 2018 •

edited

m1ga commented Mar 18, 2018

jquick-axway May 1, 2018

m1ga May 4, 2018

jquick-axway May 1, 2018

jquick-axway May 1, 2018

jquick-axway left a comment

build commented May 10, 2018 •

edited

build commented Jun 26, 2018 •

edited

hansemannn commented Jun 26, 2018 •

edited

m1ga commented Jun 27, 2018

hansemannn commented Jun 27, 2018

[TIMOB-25855] Android: TextArea lines and maxLines support #9927

[TIMOB-25855] Android: TextArea lines and maxLines support #9927

Conversation

m1ga commented Mar 11, 2018 • edited

jquick-axway commented Mar 12, 2018

m1ga commented Mar 18, 2018 • edited

m1ga commented Mar 18, 2018

jquick-axway May 1, 2018

Choose a reason for hiding this comment

m1ga May 4, 2018

Choose a reason for hiding this comment

jquick-axway May 1, 2018

Choose a reason for hiding this comment

jquick-axway May 1, 2018

Choose a reason for hiding this comment

jquick-axway left a comment

Choose a reason for hiding this comment

build commented May 10, 2018 • edited

build commented Jun 26, 2018 • edited

hansemannn commented Jun 26, 2018 • edited

m1ga commented Jun 27, 2018

hansemannn commented Jun 27, 2018

m1ga commented Mar 11, 2018 •

edited

m1ga commented Mar 18, 2018 •

edited

build commented May 10, 2018 •

edited

build commented Jun 26, 2018 •

edited

hansemannn commented Jun 26, 2018 •

edited