Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25850] : iOS SearchBar doesn't show Bookmark button when set on creation in TableView #9932

Closed
wants to merge 6 commits into from
Closed

[TIMOB-25850] : iOS SearchBar doesn't show Bookmark button when set on creation in TableView #9932

wants to merge 6 commits into from

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added the ios label Mar 13, 2018
@build
Copy link
Contributor

build commented Mar 13, 2018 •
edited

Fails
🚫

Tests have failed, see below for more information.
Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.UI.Picker TimePicker 3.803 AssertionError: expected 2018-03-20T04:14:00.750Z to equal 2018-03-20T04:14:59.224Z

Generated by 🚫 dangerJS

hansemannn
hansemannn requested changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please loop through the proxy keys instead of checking all manually.

hansemannn
hansemannn reviewed Mar 14, 2018
View reviewed changes
iphone/Classes/TiUISearchBarProxy.m

// Set search bar properties to new search bar
NSDictionary *properties = [self allProperties];
for (NSString *key in properties.allKeys) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume [self allProperties] (dynprops) cannot be nil, otherwise the app could crash here.

@hansemannn
Copy link
Collaborator

@vijaysingh-axway Do we have tests for all properties of the search-bar already? If not, please add them. We should get too easy with setting the no tests label, otherwise it might get removed again.

@build build added the ios label Mar 14, 2018
@vijaysingh-axway
Copy link
Contributor Author

@hansemannn In TIUISearchBar, getter is not implemented properly. It simply returns the value which is set in proxy. Ideally it should return value by fetching from searchbar. Currently whatever you set the value of property, it will return same even though that value is not passed to searhbar. So I am thinking to create a ticket for that, in which we can add all these property in unit tests as well. Thats why I have not added unit test in this ticket. Lets discuss on this.

@hansemannn
Copy link
Collaborator

Like it, please do so! Maybe for the 7.3.0 timeline then.

@hansemannn hansemannn added this to the 7.2.0 milestone Mar 14, 2018
@hansemannn hansemannn modified the milestones: 7.2.0, 7.3.0 Mar 14, 2018
@build build added the ios label Mar 20, 2018
@hansemannn
Copy link
Collaborator

Closing in favor of #9947

@hansemannn hansemannn closed this Mar 20, 2018
@hansemannn hansemannn removed this from the 7.3.0 milestone Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees

@ewieberappc ewieberappc

Labels
ios no tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @hansemannn @ewieberappc