(7_1_X) [TIMOB-25875] Babel rewrites app.js in classic project to generated ES5 code #9939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtcoolguy
changed the title
Generated by 🚫 dangerJS |
|
FR passed. OS Ver: 10.13.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25875
Description:
This issue was not specific to app.js. The issue here was that if a user built a project and a file had no changes through our build pipeline we'd try to symlink to the original source file as a build performance enhancement. But if subsequent builds trigger changes on a file (like transpilation would) and we write the new contents to the destination file, and it's a symlink, that modifies the original source file!
The solution here is pretty simple, if the destination file exists, remove it first before writing to it.