[TIMOB-24817] Android: Implement ListView Alloy widget support #9955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymathews
force-pushed
the
TIMOB-24817
branch
from
26b4ec6
to
78cb415
Compare
garymathews
force-pushed
the
TIMOB-24817
branch
from
8951403
to
c9e22be
Compare
garymathews
force-pushed
the
TIMOB-24817
branch
from
a00e0b0
to
4bfcb41
Compare
|
Holding to 7.4.0 to give iOS team time to do equivalent ticket: https://jira.appcelerator.org/browse/TIMOB-24776 cc @hansemannn |
sgtcoolguy
added
the
hold for parity ✋
hansemannn
reviewed
Jun 28, 2018
| // handle Alloy widgets | ||
| } else { | ||
| const widget = Module.main.require('/alloy/widgets/' + namespace + '/controllers/widget'); | ||
| if (widget) { |
There was a problem hiding this comment.
Should handle plain CommonJS modules here as well? For iOS, we use a fallback case to do this. We require common-js modules to export a view via getView as well, which is a suitable requirement to have a formal way of knowing where the main view was exported.
There was a problem hiding this comment.
@garymathews Ping! The iOS PR was just merged.
hansemannn
added
work in progress 🚧
and removed
hold for parity ✋
|
Updated PR. |
Generated by 🚫 dangerJS |
hansemannn
reviewed
Aug 3, 2018
| } else { | ||
| let widget = Module.main.require('/alloy/widgets/' + namespace + '/controllers/widget'); | ||
| if (!widget) { | ||
| Module.main.require(namespace); |
There was a problem hiding this comment.
I think the assignment is missing here? Also, this does not seem to work with native modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REQUIRES tidev/alloy#892
Titanium.UI.ListViewJIRA Ticket