Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_1_X][TIMOB-25895] Update module apiversion #9958

Merged
merged 2 commits into from Mar 29, 2018
Merged

[7_1_X][TIMOB-25895] Update module apiversion #9958

merged 2 commits into from Mar 29, 2018

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Mar 26, 2018

Cherry-pick #9956 for 7_1_X

JIRA: https://jira.appcelerator.org/browse/TIMOB-25895

Update Windows module apiversion due to TIMOB-25895. This works together with https://github.com/appcelerator/titanium_mobile_windows/pull/1213

@build
Copy link
Contributor

build commented Mar 26, 2018 •
edited

Warnings
⚠️

🔒 Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@ewanharris ewanharris self-requested a review March 29, 2018 16:02
ewanharris
ewanharris approved these changes Mar 29, 2018
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging

@ewanharris ewanharris merged commit 42fa5f9 into tidev:7_1_X Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infosia @build @ewanharris @hansemannn