Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25936] iOS: Fix appendSection & appendRow on main-thread #9986

Merged
merged 2 commits into from Apr 6, 2018
Merged

[TIMOB-25936] iOS: Fix appendSection & appendRow on main-thread #9986

merged 2 commits into from Apr 6, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.2.0 milestone Apr 6, 2018
@build build added the ios label Apr 6, 2018
@build
Copy link
Contributor

build commented Apr 6, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

ewieberappc
ewieberappc approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. Sections and rows are appended in the correct order. Tested using the provided code as well as modifications to the project to append in different ways and/or orders.

@ewieberappc ewieberappc merged commit cd8f927 into tidev:master Apr 6, 2018
build pushed a commit to garymathews/titanium_mobile that referenced this pull request Apr 23, 2018
@hansemannn @sgtcoolguy
[TIMOB-25936] iOS: Fix appendSection & appendRow on main-thread (tide…
be13242 
…v#9986)

* [TIMOB-25936] Fix appendSection & appendRow on main-thread

* Update ti.ui.tableview.addontest.js
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewieberappc ewieberappc ewieberappc approved these changes

Assignees
No one assigned
Labels
bug ios
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @ewieberappc @sgtcoolguy