Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-13626 - Prevented click event from firing after touch move #29

Merged
merged 2 commits into from Apr 22, 2013

Conversation

pec1985
Copy link
Contributor

@pec1985 pec1985 commented Apr 19, 2013

Test code:

var win = Ti.UI.createWindow({
    backgroundColor: 'white'
});

var scrollView = Ti.UI.createScrollView({
    backgroundColor: 'white',
    layout: 'vertical',
    contentWidth: Ti.UI.FILL,
    contentHeight: Ti.UI.SIZE
});

for(var i = 0; i < 20; i++) {
    var btn = Ti.UI.createButton({
        top: 10,
        title: 'Hello'
    });
    scrollView.add(btn);
}

win.add(scrollView);

scrollView.addEventListener('click', function(e){
    Ti.API.info(JSON.stringify(e));
});

win.open();

@@ -237,19 +240,21 @@ class UIViewEventHandler : public QObject {
y = event->localY();

// TODO(josh): Include coordinates of "click".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove this TODO as well.

@joshthecoder
Copy link
Contributor

Code reviewed and tested. LGTM.

Don't worry about that comment, we can remove it later.

joshthecoder added a commit that referenced this pull request Apr 22, 2013
TIMOB-13626 - Prevented click event from firing after touch move
@joshthecoder joshthecoder merged commit 8565e67 into appcelerator-archive:master Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants