Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement important Titanium.UI.ScrollableView functionality #31

Merged
merged 6 commits into from May 9, 2013
Merged

Implement important Titanium.UI.ScrollableView functionality #31

merged 6 commits into from May 9, 2013

Conversation

pec1985
Copy link
Contributor

@pec1985 pec1985 commented Apr 25, 2013

Methods exposed:

addView()
moveNext()
movePrevious()
scrollToView()

Properties exposed

setViews()
setCurrentPage()

@joshthecoder
Copy link
Contributor

There's some mixing of indentation. Make sure you indent each line uses 4 spaces.

joshthecoder
joshthecoder reviewed Apr 25, 2013
View reviewed changes
src/tibb/TiScrollableView/TiScrollableView.h
#include <bb/cascades/ScrollView>


namespace bb{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forward declare third party classes this way.
Add #include <bb/cascades/Container> instead.

@joshthecoder
Copy link
Contributor

@pec1985 Can you merge master with your branch, there seems to be some conflicts that won't let us merge.

@pec1985
Merge branch 'refs/heads/master' into TIMOB-8831
d21bc7e 
Conflicts:
	src/tibb/tibb.pro
	test/apps/native/tibbtest/x86/o-g/tibbtest
@pec1985
Copy link
Contributor Author

pec1985 commented May 6, 2013

Done

@joshthecoder
Copy link
Contributor

LGTM. Accepted.

joshthecoder added a commit that referenced this pull request May 9, 2013
@joshthecoder
Merge pull request #31 from pec1985/TIMOB-8831
84af7db 
Implement important Titanium.UI.ScrollableView functionality
@joshthecoder joshthecoder merged commit 84af7db into appcelerator-archive:master May 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pec1985 @joshthecoder