New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-8814 - Simple animation #35
TIMOB-8814 - Simple animation #35
Conversation
Conflicts: src/tibb/NativeObjectFactory.cpp
@@ -154,6 +154,7 @@ class NativeControlObject : public NativeProxyObject | |||
static int getBoolean(TiObject* obj, bool* value); | |||
static int getFloat(TiObject* obj, float* value); | |||
static int getInteger(TiObject* obj, int* value); | |||
static int getStdString(TiObject* obj, std::string* value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not add another V8 string conversion method. Use V8Utils V8StringToQString().
You can get a std::string if you really need it from a QString using toStdString().
We should really void std::string since it isn't unicode safe, but for layout properties it might be okay for now.
Code review finished. Please address comments and also re-merge with master to fix merge conflicts. Thanks. |
Conflicts: src/tibb/NativeObject.h src/tibb/TiUIObject.cpp src/tibb/TiUIObject.h
Conflicts: src/tibb/NativeControlObject.cpp src/tibb/NativeControlObject.h src/tibb/NativeObjectFactory.cpp
Fixed PR, there were several conflicts from different pull requests |
Tested and code reviewed. LGTM. |
Conflicts: src/tibb/NativeObjectFactory.cpp src/tibb/TiUIObject.cpp
TIMOB-8814 - Simple animation
Test: