[TIMOB-24297] Add NDK r13c and r14 compatibility #19
Conversation
garymathews
force-pushed
the
TIMOB-24297
branch
2 times, most recently
from
ebca98a
to
b393bdb
Compare
garymathews
force-pushed
the
TIMOB-24297
branch
3 times, most recently
from
6c6be19
to
0eccf77
Compare
Jenkinsfile
Outdated
| @@ -43,6 +45,18 @@ timestamps { | |||
| } // stage | |||
|
|
|||
| stage('Setup') { | |||
|
|
|||
| // download NDK | |||
There was a problem hiding this comment.
uh, so this block makes no sense whatsoever here.You're requesting a linux node and an OS X node to grab the ndk and unzip it, but not keeping the result.
Basically this says: Give me a 'linux' (or 'osx') machine, create a temporary workspace/directory, download the idk and unzip it (and then clean up the workspace and free up the machine)
Not to mentioned this section of the build is already wrapped in a node block so it's already working on a specific machine with a workspace allocated.
There was a problem hiding this comment.
I'm already tying the build to OS X nodes anyways, so just download the darwin ndk version, and unzip it into the working directory, then when we stash the workspace later it'll be included.
Jenkinsfile
Outdated
| @@ -4,7 +4,7 @@ def build(arch, mode) { | |||
| // FIXME Technically we could build on linux as well! | |||
| node('osx && git && android-ndk') { | |||
| unstash 'sources' | |||
| sh "./build_v8.sh -n /opt/android-ndk-r11c -j8 -l ${arch} -m ${mode}" | |||
| sh "./build_v8.sh -n /opt/android-ndk-r14b -j8 -l ${arch} -m ${mode}" | |||
There was a problem hiding this comment.
and up here, don't point to /opt/android-ndk-r14b because no build machine has that path yet. Instead have it use the android sdk you downloaded earlier in the initial phases and states in 'sources' and unstashed here. so:
sh "./build_v8.sh -n ./android-ndk-r14b -j8 -l ${arch} -m ${mode}"
Jenkinsfile
Outdated
| @@ -36,6 +34,8 @@ timestamps { | |||
| userRemoteConfigs: scm.userRemoteConfigs | |||
| ]) | |||
|
|
|||
| sh 'git clean -dffx' | |||
There was a problem hiding this comment.
this git clean done manually may mess up the state of the workspace and you may not be building the correct commit as a result...
garymathews
force-pushed
the
TIMOB-24297
branch
6 times, most recently
from
872a37f
to
f4a077f
Compare
.travis.ymlbuild fileJenkinsfilebuild file5.7, 5.8 and 5.95.7.54.0, the last version legacy debug protocols are availablebuild_v8.shmakecommand-O2JIRA Ticket