7.3-lkgr #44
Merged
7.3-lkgr #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymathews
force-pushed
the
7.3-lkgr
branch
3 times, most recently
from
30664b9
to
1ce564b
Compare
garymathews
commented
Mar 23, 2019
android.patch
Outdated
| 'mixins': { | ||
| 'android': { | ||
| - 'gn_args': 'target_os="android" v8_android_log_stdout=true', | ||
| + 'gn_args': 'target_os="android" v8_android_log_stdout=false', |
There was a problem hiding this comment.
Set v8_android_log_stdout to false as we want to output using __android_log
garymathews
commented
Mar 23, 2019
| @@ -8,10 +8,10 @@ def build(scm, arch, mode) { | |||
| def expectedLibraries = ['monolith'] | |||
| def labels = 'ninja && git && android-ndk && android-sdk && python' | |||
| if (arch.equals('ia32') || arch.equals('arm')) { | |||
| labels += ' && (linux || (osx && xcode-9))' // Need xcode-9 or older on mac, as 32-bit x86 was removed in xcode 10 | |||
| labels += ' && (osx && xcode-9)' // Need xcode-9 or older on mac, as 32-bit x86 was removed in xcode 10 | |||
There was a problem hiding this comment.
Only build on osx nodes as we want a macOS compatible mksnapshot
garymathews
force-pushed
the
7.3-lkgr
branch
5 times, most recently
from
5258d5a
to
f5e6c43
Compare
garymathews
commented
Mar 31, 2019
| common_optimize_on_cflags += [ | ||
| # Put data in separate COMDATs. This allows the linker | ||
| # to put bit-identical constants at the same address even if | ||
| # they're unrelated constants, |
There was a problem hiding this comment.
Use -Ofast instead of -O3
garymathews
commented
Mar 31, 2019
| "-Wl,--exclude-libs=libvpx_assembly_arm.a", | ||
| ] | ||
|
|
||
| # libc++ |
There was a problem hiding this comment.
Specify NDK libc++ headers
garymathews
commented
Mar 31, 2019
| @@ -44,7 +44,9 @@ template("android_clang_toolchain") { | |||
| # The tools should be run relative to the build dir. | |||
| _tool_prefix = rebase_path("$_android_tool_prefix", root_build_dir) | |||
|
|
|||
| _prefix = rebase_path("$clang_base_path/bin", root_build_dir) | |||
| # Use android ndk clang | |||
| _prefix = "$android_ndk_root/toolchains/llvm/prebuilt/darwin-x86_64/bin" | |||
There was a problem hiding this comment.
Use NDK clang instead of pre-built dependency
This was referenced Mar 31, 2019
garymathews
force-pushed
the
7.3-lkgr
branch
10 times, most recently
from
770d949
to
47ebdb1
Compare
garymathews
force-pushed
the
7.3-lkgr
branch
18 times, most recently
from
1130db5
to
e075e81
Compare
sgtcoolguy
approved these changes
Apr 8, 2019
|
so I see you pegged us to osx nodes - does this mean the mksnapshot will only work on Mac? What about Windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 7.3.492.26mksnapshotto create memory snapshots