Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17515] Consolidated all Windows Phone and Windows Store functionality into windowslib. #1

Merged
merged 5 commits into from Nov 12, 2014

Conversation

…onality into windowslib.

This commit also resolves:

* [TIMOB-17853] Proxy Emulator Log Statements
* [TIMOB-17852] Install app to Emulator
* [TIMOB-17851] Launch Emulator
* [TIMOB-17856] Proxy Device Log Statements
* [TIMOB-17854] Connect to Device
@sgtcoolguy
Copy link
Contributor

So once we got the execution policy ironed out, the tests mostly worked.
The user needs to open PowerShell and run:

Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser

I assume we'd want to guide the user to do this in some sort of setup command?

I'm still seeing failures on the log-relay tests:

  1) log relay start log relay, receive UDP signal, respond with TCP port & toke
ns, and shutdown:
     RangeError: Port should be > 0 and < 65536
      at Socket.send (dgram.js:268:11)
      at Context.<anonymous> (C:\windowslib\test\test-logrelay.js:32:10)
      at Test.Runnable.run (C:\windowslib\node_modules\mocha\lib\runnable.js:217
:15)
      at Runner.runTest (C:\windowslib\node_modules\mocha\lib\runner.js:373:10)
      at C:\windowslib\node_modules\mocha\lib\runner.js:451:12
      at next (C:\windowslib\node_modules\mocha\lib\runner.js:298:14)
      at C:\windowslib\node_modules\mocha\lib\runner.js:308:7
      at next (C:\windowslib\node_modules\mocha\lib\runner.js:246:23)
      at Object._onImmediate (C:\windowslib\node_modules\mocha\lib\runner.js:275
:5)
      at processImmediate [as _immediateCallback] (timers.js:345:15)

  2) log relay start log relay, connect to TCP server, send message, receive, an
d shutdown:
     Error: timeout of 5000ms exceeded
      at null.<anonymous> (C:\windowslib\node_modules\mocha\lib\runnable.js:158:
19)
      at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

I think maybe the first test is outdated since the UDP portion is no longer part of your solution?

And if the attached Windows device is asleep, the tests which try to connect to the device fail:

  1) device connect to a device:
     Uncaught Error: Failed to connect to device "0"
      at ChildProcess.<anonymous> (C:\windowslib\lib\wptool.js:304:16)
      at ChildProcess.emit (events.js:98:17)
      at maybeClose (child_process.js:756:16)
      at Process.ChildProcess._handle.onexit (child_process.js:823:5)

@sgtcoolguy
Copy link
Contributor

OK, with the latest push the only caveats left are the execution policy change and making sure the connected device is unlocked/not asleep. I think that's good enough to get this merged.

sgtcoolguy added a commit that referenced this pull request Nov 12, 2014
[TIMOB-17515] Consolidated all Windows Phone and Windows Store functionality into windowslib.
@sgtcoolguy sgtcoolguy merged commit 49e73f9 into appcelerator-archive:master Nov 12, 2014
@pinnamur
Copy link
Contributor

Yay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants