Fix TIMOB-18958 Windows: CLI builds hang on first try due to Powershe… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll permission check in windowslib
|
Yeah, I can reproduce this. |
|
The PR fixed most of the errors I was seeing around the execution policy. It was still failing to detect if the emulator was running, but once I applied the fix to this last bit of code, everything worked well for me. All tests pass for me (except for the ones interacting with a device, because I don't have one to connect). So is it ok if we change the two instances of |
|
Yeah, I must have missed that file when I did my pass. Let me update the PR with it. |
|
Merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll permission check in windowslib
Use the -ExecutionPolicy Bypass -File args to avoid having to set execution policy manually to run scripts in files.