Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.3.0, support Windows 10 detection/usage without requiring 8.1 tooling as well #29

Merged
merged 2 commits into from Jan 7, 2016

Conversation

sgtcoolguy
Copy link
Contributor

  • We now detect 8.0/8.1 and 10 in parallel. Before we'd look for 8.0/8.1 first and if we didn't find one of those we wouldn't try to get win 10.
  • Should be slightly faster detection now because of that?
  • Mark 8.1/8.0 supported flag as "false" if we can't find the deploy command, that means by default Windows 10 will be "selected" if we find entries for 8.1 but not the tooling.
  • Tested by removing my windows 8.1 SDK/tooling through VS2015 Update 1. It actually keeps some stuff around (like XapSignTool), but removes the AppDeployCmd and in that case we list 8.1 in our entry but as unsupported and 10 is chosen as the preferred/selected.

https://jira.appcelerator.org/browse/TIMOB-20198

@infosia
Copy link
Contributor

infosia commented Jan 7, 2016

Looks good to me.

I found a issue in different area:
https://github.com/sgtcoolguy/windowslib/blob/TIMOB-20198/lib/wptool.js#L761

  • result is not defined at emitter.emit(result || 'error', err)
function (next) {
    if (options.appGuid) {
        guid = options.appGuid;
        next();
    } else {
        getProductGUID(appPath, options, function(err, productGuid) {
            if (err) {
                emitter.emit(result || 'error', err);
                return next(err);
            }

            guid = productGuid;
            next();
        });
    }
}

Otherwise ok to merge, feel free to self-merge this once the issue above is fixed.

sgtcoolguy added a commit that referenced this pull request Jan 7, 2016
Bump to 0.3.0, support Windows 10 detection/usage without requiring 8.1 tooling as well
@sgtcoolguy sgtcoolguy merged commit 31e3d72 into appcelerator-archive:master Jan 7, 2016
@sgtcoolguy sgtcoolguy deleted the TIMOB-20198 branch January 7, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants