Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24668] Update VS2017 detection logic to prevent error with VS2015 #70

Merged
merged 2 commits into from Jul 4, 2017
Merged

[TIMOB-24668] Update VS2017 detection logic to prevent error with VS2015 #70

merged 2 commits into from Jul 4, 2017

Conversation

ewanharris
Copy link

@ewanharris ewanharris commented Jun 20, 2017 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-24668

Update the VS2017 detection logic based off the currently recommended solution here

Note:

I have not tested this on VS2017 yet

@infosia infosia self-requested a review July 4, 2017 12:48
infosia
infosia approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@infosia infosia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works good with VS2017 as well. Would you bump up the version together with #71 ?

@infosia infosia merged commit 677b248 into appcelerator-archive:master Jul 4, 2017
@ewanharris ewanharris mentioned this pull request Jul 7, 2017
Closed
@ewanharris ewanharris mentioned this pull request Jul 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infosia infosia infosia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewanharris @infosia