[TIMOB-24683] Do not attempt to run winappdeploycmd if it does not exist #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Version bump? |
|
Ack of course, will push now |
ewanharris
force-pushed
the
TIMOB-24683
branch
11 times, most recently
from
3291453
to
bffa01b
Compare
ewanharris
force-pushed
the
TIMOB-24683
branch
9 times, most recently
from
591987d
to
99390e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24683
It looks like in VS2017 it is possible to install a Windows 10 SDK and there not be a winappdeploycmd (or VS is still not great at uninstalling cleanly). So if the deploycmdproperty does not exist don't try and detect devices
Verification
See jira