Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24958] Fix detection of SDK specific winappdeploycmd #75

Merged
merged 1 commit into from Aug 16, 2017

Conversation

ewanharris
Copy link

JIRA: https://jira.appcelerator.org/browse/TIMOB-24958

After detecting the 'globally installed' winappdeploycmd,

  • Search through the bin directory for folders that match a regex for the 10 SDK.
  • Search the bin\x86 folder of each SDK for winappdeploycmd.exe

This means that we moving forward we will take the highest version of the tool on the system (also just to call out what the differences are the one under 10.0.15063 has a -preserveAppData flag which might be useful for us).

For example:

  • VS 2017 with only 10.0.15063.0 will take the winappdeploycmd under C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x86
  • VS 2017 with 10.0.15063.0 and 10.0.14393.0 will take the winappdeploycmd under C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x86
  • VS 2017 with only 10.0.14393.0 will take the winappdeploycmd under C:\Program Files (x86)\Windows Kits\10\bin\x86
  • VS 2015 with 10.0.15063.0 (manually installed) and 10.0.14393.0 will take the winappdeploycmd under C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x86 (although we cannot build with this SDK, the tooling underneath works just fine)
  • VS 2015 with only 10.0.14393.0 will take the winappdeploycmd under C:\Program Files (x86)\Windows Kits\10\bin\x86

Verification

  1. Test building to Windows 10 devices
  2. Test ti info (and Studio) can detect Windows 10 devices

@ewanharris
Copy link
Author

ewanharris commented Aug 15, 2017

Looks like the node.js version on the C# travis setup is stupid old.... {"node":"0.10.36","npm":"1.4.28"}), #73 removes this and the yarn usage

Copy link
Contributor

@infosia infosia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@infosia infosia merged commit 3d0e841 into appcelerator-archive:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants