Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25027] Filter emulators based off supportedWindowsPhoneSDKVersions parameter #78

Merged
merged 3 commits into from Oct 6, 2017

Conversation

ewanharris
Copy link

@ewanharris ewanharris commented Aug 30, 2017

  • If the user of this library specifies the supportedWindowsPhoneSDKVersions option then we will only detect and report the emulators for that version
  • Added coverage to the library. I only added coverage to the main mocha test run as adding to the others seems pointless given that they only target a single file. Current results are below, I don't believe it's enforcing any percentage right now but I need to double check (update, travis passed so yeah there is no enforcement of percentages currently)
------------------|----------|----------|----------|----------|----------------|
File              |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
------------------|----------|----------|----------|----------|----------------|
All files         |    59.77 |    47.37 |    70.29 |    59.58 |                |
 windowslib       |    33.87 |        0 |        0 |    34.43 |                |
  index.js        |    33.87 |        0 |        0 |    34.43 |... 150,151,152 |
 windowslib/lib   |    60.78 |    48.39 |    73.09 |    60.56 |                |
  assemblies.js   |    73.17 |    73.33 |    71.43 |    73.17 |... ,76,104,109 |
  certs.js        |    16.91 |     3.95 |    17.65 |    16.91 |... 312,314,315 |
  device.js       |    61.25 |     47.5 |    68.75 |    61.25 |... 198,199,200 |
  emulator.js     |    70.65 |    68.04 |     87.5 |    70.65 |... 434,450,454 |
  env.js          |    75.61 |       75 |      100 |    79.49 |... ,97,112,113 |
  logrelay.js     |    80.77 |    73.53 |     87.5 |    80.77 |... 106,146,147 |
  process.js      |     91.3 |    86.67 |      100 |    92.86 |       44,45,46 |
  utilities.js    |    70.45 |    57.69 |       90 |    70.45 |... 100,101,103 |
  visualstudio.js |    68.71 |    58.33 |       80 |    68.32 |... 413,414,415 |
  windowsphone.js |    93.52 |    70.69 |      100 |    93.14 |... 247,251,257 |
  winstore.js     |    46.77 |    32.77 |    42.86 |    45.96 |... 424,456,462 |
  wptool.js       |    55.65 |    40.68 |    70.97 |    55.67 |... 8,1058,1059 |
------------------|----------|----------|----------|----------|----------------|

=============================== Coverage summary ===============================
Statements   : 59.77% ( 988/1653 )
Branches     : 47.37% ( 406/857 )
Functions    : 70.29% ( 239/340 )
Lines        : 59.58% ( 973/1633 )
================================================================================

Verification

This isn't really doesn't have proper verification steps until the titanium_mobile_windows PR is ready. So I'll update it then

@infosia infosia self-requested a review September 7, 2017 06:25
Copy link
Contributor

@infosia infosia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @ewanharris Do you want me to merge this? I guess the only concern is version number, I would push this as 0.5.6 as we highly likely merge #79 soon because it's critical.

@ewanharris
Copy link
Author

ewanharris commented Sep 7, 2017

@infosia Yeah I think if we merge #79 first and then this once that is merged and published. I bumped to 0.6.0 as this is technically a new feature so minor bump seemed appropriate

@infosia infosia merged commit bc1040e into appcelerator-archive:master Oct 6, 2017
@ewanharris ewanharris deleted the TIMOB-25207 branch April 2, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants