Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25616] Don't forceUnInstall unless user explicitly specifies it #83

Merged
merged 4 commits into from Jan 22, 2018
Merged

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Dec 19, 2017

TIMOB-25616

Windowslib have been uninstalling existing app in order to complete the installation when same version of the app is already installed, but we should not uninstall existing app unless user explicitly specifies forceUnInstalloption. It should ends up showing error message when forceUnInstall=false and there's same version of the app installed, which should be the default behavior of wpToolInstall.

Copy link

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@infosia infosia merged commit db69099 into appcelerator-archive:master Jan 22, 2018
@infosia infosia deleted the TIMOB-25616 branch January 22, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants