Adds an epic looking dark theme called "Obsidium" #144
Conversation
|
We'll take a look at this tomorrow, thanks |
|
I think you actually want to create a theme as I commented here: bbedward/flutter_barcode_reader#1 -- In pubspec.yaml you can change the flutter_barcode_reader reference to your fork too, https://github.com/mintware-de/flutter_barcode_reader That would make it so I can run the workflow on this PR and get an APK to check out. |
|
I am able to build the app on my emulator. I tried looking into the error messages given by the checks, but could not get anywhere with them. |
|
I'm good with this, but will wait for @yekta to review. Can you also change back the pubspec reference to bbedward/flutter_barcode_reader since I merged your theme there. |
| @@ -437,7 +437,80 @@ class ThoriumTheme extends BaseTheme { | |||
| AppIconEnum appIcon = AppIconEnum.THORIUM; | |||
| } | |||
|
|
|||
| enum AppIconEnum { NATRIUM, TITANIUM, INDIUM, NEPTUNIUM, THORIUM } | |||
There was a problem hiding this comment.
I missed this actually, AppIconEnum is for on iOS devices the app icon changes with the theme, but since there is no icon for your theme you should just use the NATRIUM (default) icon.
lib/themes.dart
Outdated
| @@ -447,6 +520,9 @@ class AppIcon { | |||
| } | |||
| String iconStr = "natrium"; | |||
| switch (iconToChange) { | |||
| case AppIconEnum.OBSIDIUM: | |||
| iconStr = "obsidium"; | |||
| break; | |||
| } | ||
|
|
||
| enum AppIconEnum { NATRIUM, TITANIUM, INDIUM, NEPTUNIUM, THORIUM, OBSIDIUM } | ||
|
|
lib/themes.dart
Outdated
| BoxShadow boxShadowButton = BoxShadow(color: Colors.transparent); | ||
|
|
||
| OverlayTheme qrScanTheme = OverlayTheme.OBSIDIUM; | ||
| AppIconEnum appIcon = AppIconEnum.OBSIDIUM; |
There was a problem hiding this comment.
Change this to AppIconEnum.NATRIUM
|
Thanks for the PR @tlietz. We'll be doing some tweaks to the theme but it'll be released pretty soon. |
In order for this to be successful, the PR at https://github.com/bbedward/flutter_barcode_reader/pull/1 needs to be accepted so that barcode_scan.dart has
OBSIDIUMdefined.