-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared ENV variables for project. #44
Comments
The shared_env branch contains the solution. We thought of the best solution and we came with this: %env% => env RAILS_ENV=test BUNDLE_GEMFILE=%build_dir%/Gemfile We can do:
Any thoughts? |
I would prefere to put this as a build part and forget about everything else...
I don't feel like "the build script" should be hosted within the app code VCS and when/or if the |
The build part tries to be as much agnostic as it can be. It's just a list of command shells. The thing here is that the commands do not know anything even about each other. They are simply processes spawn from the bigtuna's main process, line by line. This way you get stdout/stderr split up, and also your build process stops if any of the commands fails. Sure, we can store the shell script in some executable file (like /build_dir/build.sh) and the just run it within shell, but this leaves us with no error handling (what if some command fails?) and doesn't distinguish build 'parts' (like migration, then tests, then something). You can address this by doing command1 && command2 && command3 but this gets just ugly, doesn't it? |
And also just to be clear, it has always been this way in BigTuna :-) We are always happy to discuss solutions though, maybe we can figure out something that pleases both sides. When coding this solution we thought mainly about leaving as much space for many scenarios user's can build their apps, and also leave the BigTuna features like non-zero exit code breaks the build, and separate outputs of commands. |
aren't build parts executed in parallel? |
Build parts meaning build configurations? Nope, they are executed in order (of creation, AFAIR). |
wuputah raised a valid issue for sharing some ENV variables in every step of a project. This might be useful for example in setting GEMFILE_PATH or RAILS_ENV.
The text was updated successfully, but these errors were encountered: