Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hphpdoc\Collector has a non-<?hh grandparent #1

Open
ghost opened this issue Dec 23, 2016 · 2 comments
Open

Hphpdoc\Collector has a non-<?hh grandparent #1

ghost opened this issue Dec 23, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 23, 2016

When running hphpdoc with hhvm version 3.15.2, the typechecker throws an error:

Catchable fatal error: Hack type error: Hphpdoc\Collector has a non-<?hh grandparent; this is not allowed in strict mode because that parent may define methods of unknowable name and type at .../vendor/appertly/hphpdoc/src/Collector.hh line 31

@ghost
Copy link
Author

ghost commented Dec 23, 2016

This issue can be fixed by depending on hackification/log instead of psr/log. (It's a Hacklang PSR log replacement maintained by me, still in the making.)

@doublecompile
Copy link
Contributor

If you take a look at our composer.json, we depend on the following in the dev dependencies.

"libreworks/psr3-log-hhi": "^1.0.0"

This is a set of Hack typechecker definitions for the PSR-3 package.

Also, this executable is meant to be run without the type checker. If you're running from the command line, you can do:

hhvm -d hhvm.hack.lang.look_for_typechecker=0 /path/to/hphpdoc 

Perhaps we should add this CLI flag that to the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant