-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCM device groups #130
Comments
@baskin I briefly looked at the snippet from node-gcm and the FCM documentation. From the docs it seems that |
As the So with these 3 recipient options
|
@baskin thank you for the clarification. |
Correct. |
Hi @baskin I implemented a solution that allows to pass on custom Could you test it with the https://github.com/appfeel/node-pushnotifications/tree/dev/fcm-recipients branch and let me know if it works as expected for you? Thank you! |
Thanks @alex-friedl Quick thought. The current API semantics are sth like IMHO it would be cleaner from an API usability standpoint. What do you think? |
Hi @baskin, I agree that this may be preferable upon first glance and I looked into at first as well.
Neither would it be possible to know if to or condition is the desired recipient , because the regId list is only an array containing device tokens for all possible devices.
The idea of my current API proposal is to specifically override the default behaviour for GCM only, without the need to introduce any breaking changes. Does that make sense? Or do you see an alternative solution that would work? |
@baskin any update from your end? Did you get around to testing it? Does the proposed API work for you? |
This makes sense. Thanks @alex-friedl Sorry. Didn't get a chance to test so far. I'm not using this library directly but via the library notifme-sdk. I've asked the author of that library to take a look too. Pl allow me a few days. |
@baskin Judging from notifme/notifme-sdk#69 (comment) the suggested solution should work for you? I will merge and release this change. |
Hi Team,
I wasn't able to figure out how to send an FCM notification to a device group. Any help would be greatly appreciated? FWIW, the underlying library used (https://github.com/ToothlessGear/node-gcm) supports sending to device groups.
Thanks,
The text was updated successfully, but these errors were encountered: