check to avoid tricky redirects

appharbor · Aug 14, 2012 · b6f157e · b6f157e
1 parent 4a9d409
commit b6f157e
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/AuthenticationExample.Web/Controllers/SessionController.cs b/AuthenticationExample.Web/Controllers/SessionController.cs
@@ -1,4 +1,5 @@
-using System.Linq;
+using System;
+using System.Linq;
 using System.Web.Mvc;
 using AppHarbor.Web.Security;
 using AuthenticationExample.Web.Model;
@@ -48,9 +49,14 @@ public ActionResult Create(SessionViewModel sessionViewModel)
 			if (ModelState.IsValid)
 			{
 				_authenticator.SetCookie(user.Username);
-				if (!string.IsNullOrEmpty(sessionViewModel.ReturnUrl))
+				var returnUrl = sessionViewModel.ReturnUrl;
+				if (!string.IsNullOrEmpty(returnUrl))
 				{
-					return Redirect(sessionViewModel.ReturnUrl);
+					var returnUri = new Uri(returnUrl);
+					if (!returnUri.IsAbsoluteUri || returnUri.Host == Request.Url.Host)
+					{
+						return Redirect(sessionViewModel.ReturnUrl);
+					}
 				}
 
 				return RedirectToAction("Index", "Home");