Use nativeEvent argument in onLayout instead of container.measure #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.container.measure
was not returning the fullheight
andwidth
if the screen was in the middle of a transition. This caused a miscalculation where the full container view was not taken up. Example:onLayout
(http://facebook.github.io/react-native/releases/0.45/docs/view.html#onlayout) receives the same view's dimensions withevent.nativeEvent.layout
. The docs suggest using those instead(http://facebook.github.io/react-native/releases/0.45/docs/direct-manipulation.html#measure-callback).
This change sets the correct
width
andheight
and gives the expected behavior instead: