Improve processLogToGetobservatory for Flutter >= 3.0.0 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VM service message introduced with Dart 2.17 dart-lang/sdk#46756 and used by Flutter since 3.0.0
|
Could you append the log as a comment as well? |
|
You are correct @KazuCocoa - I checked the log and it says So this PR needs to be changed. |
VM service message introduced with Dart 2.17 dart-lang/sdk#46756 and used by Flutter since 3.0.0
KazuCocoa
approved these changes
Jun 9, 2022
|
thank you! |
|
I'll update current test failures and then create a new version. Hopefully this weekend. |
|
v1.1.0 has this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the VM service message was changed in Dart 2.17 (used by Flutter >= 3.0.0)
dart-lang/sdk#46756
This PR aims to fix this.