Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update integerationapp for newer OS env #891

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Apr 19, 2024

IntegerationApp has a few deprecations. This PR fixed them.

I have tested these changes with simulators and a real device.

The notification thing is to show below once.

Screenshot 2024-04-19 at 12 38 01 AM

@mykola-mokhnach
Copy link

is it chore or fix?

@@ -22,12 +22,12 @@
<string>1</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>NSLocationAlwaysAndWhenInUseUsageDescription</key>
<string>Yo Yo</string>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo!

Copy link

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating that @KazuCocoa

@KazuCocoa
Copy link
Member Author

This is for integration app's kind of "update" for newer OSs, so not "fix" which actual WDA behavior. Hm, let me modify the title as update integration app

@KazuCocoa KazuCocoa changed the title chore: fix integerationapp chore: update integerationapp for newer OS env Apr 19, 2024
@KazuCocoa KazuCocoa merged commit 2c78348 into master Apr 19, 2024
46 checks passed
@KazuCocoa KazuCocoa deleted the fix-integerationapp branch April 19, 2024 19:52
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
## [8.5.3](v8.5.2...v8.5.3) (2024-04-19)

### Miscellaneous Chores

* update integerationapp for newer OS env ([#891](#891)) ([2c78348](2c78348))
Copy link

🎉 This PR is included in version 8.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants