Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle to build instead of Maven #214

Closed
Jonahss opened this issue Jul 7, 2015 · 12 comments
Closed

Use Gradle to build instead of Maven #214

Jonahss opened this issue Jul 7, 2015 · 12 comments
Assignees
Milestone

Comments

@Jonahss
Copy link
Member

Jonahss commented Jul 7, 2015

suggested by @bootstraponline to align with other Android and Appium projects. Maven is unsupported by Google.

@bootstraponline
Copy link
Member

Important: Support for the Android Developer Tools (ADT) in Eclipse is ending, per our announcement. You should migrate your app development projects to Android Studio as soon as possible. For more information on transitioning to Android Studio, see Migrating to Android Studio.

https://developer.android.com/tools/help/adt.html

@Jonahss
Copy link
Member Author

Jonahss commented Jul 7, 2015

I use intellij. That all right?

@bootstraponline
Copy link
Member

Android Studio is built on Intellij so Intellij has excellent gradle support.

@Jonahss
Copy link
Member Author

Jonahss commented Jul 7, 2015

👍

@coding-yogi
Copy link
Contributor

I am using intellij, I can look into this one

@coding-yogi
Copy link
Contributor

Was trying to get my fork running with Gradle and having a hard time compiling this List

I get the below error
javaclient\java-client\src\main\java\io\appium\java_client\AppiumDriver.java:84: error: findElements(By) in AppiumDriver cannot implement findElements(By) in WebDriver
public List findElements(By by){
^
return type List is not compatible with List
where RequiredElementType is a type-variable:
RequiredElementType extends WebElement declared in class AppiumDriver

I tried typecasting return value to List with no luck

@coding-yogi
Copy link
Contributor

javaclient\java-client\src\main\java\io\appium\java_client\AppiumDriver.java:84: error: findElements(By) in AppiumDriver cannot implement findElements(By) in WebDriver
public List< RequiredElementType > findElements(By by){
^
return type List< RequiredElementType > is not compatible with List< WebElement >
where RequiredElementType is a type-variable:
RequiredElementType extends WebElement declared in class AppiumDriver

@coding-yogi
Copy link
Contributor

@Jonahss @TikhomirovSergey , Gradle uses javac and it seems it is pretty stringent than eclipse or intellij compilers when it comes to Generics. I am not sure if there can be a workaround to overcome this w/o making code changes around handling generics

Per error even if RequiredElementType extends WebElement, it doesn't translate into List < RequiredElementType > extends List < WebElement >
and hence the declaration of overridden method is invalid as per the compiler

@TikhomirovSergey
Copy link
Contributor

@aniket-21 Sorry for my late responce Too busy.
The fix is here:
SeleniumHQ/selenium#863
We need the Selenium version with these changes. Also I'll try to find a way to avoid this problem with Gradle too.

@TikhomirovSergey
Copy link
Contributor

#220

@coding-yogi
Copy link
Contributor

Thanks @TikhomirovSergey , It would be good to have the implementation changes at Selenium end rather than forcing the compilers to accept current one with warnings :)

@TikhomirovSergey
Copy link
Contributor

Was implemented at #442 #465. @aniket-21 Please wait for v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants